Messages in this thread | | | Date | Wed, 29 Jun 2011 14:19:28 +0300 | From | Avi Kivity <> | Subject | Re: [PATCH v2 03/22] KVM: x86: fix broken read emulation spans a page boundary |
| |
On 06/29/2011 01:53 PM, Xiao Guangrong wrote: > On 06/29/2011 04:21 PM, Avi Kivity wrote: > > >> > >> - if (kvm_read_guest_virt(ctxt, addr, val, bytes, exception) > >> - == X86EMUL_CONTINUE) > >> + if (!kvm_read_guest(vcpu->kvm, gpa, val, bytes)) > >> return X86EMUL_CONTINUE; > > > > This doesn't perform the cpl check. > > > > Firstly, it calls kvm_mmu_gva_to_gpa_read to translate gva to gpa, and cpl > is checked in this function, it is not enough?
You are right, it is enough. I don't know how I missed it.
-- error compiling committee.c: too many arguments to function
| |