lkml.org 
[lkml]   [2011]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v4]PPC4xx: Adding PCI(E) MSI support
    From
    Date
    On Tue, 2011-06-28 at 17:31 -0500, Ayman El-Khashab wrote:
    > > > +static int ppc4xx_setup_pcieh_hw(struct platform_device *dev,
    > > > + struct resource res, struct
    > ppc4xx_msi *msi)
    > > > +{
    > > > +
    >
    > <snip>
    >
    > > > +
    > > > + msi->msi_dev = of_find_node_by_name(NULL, "ppc4xx-msi");
    > > > + if (msi->msi_dev)
    > > > + return -ENODEV;
    >
    > This does not look correct. I guess it should probably read
    >
    > if (!msi->msi_dev) .....

    Indeed, that looks bogus. Rupjyoti, please test and send fixes if
    necessary, obviously this code has not been tested.

    This is not part of the bits I fixed up so I looks to me like the
    original patch was wrong (and thus obviously untested !!!)

    Cheers,
    Ben.




    \
     
     \ /
      Last update: 2011-06-29 01:19    [W:0.024 / U:30.852 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site