Messages in this thread | | | Date | Tue, 28 Jun 2011 17:31:31 -0500 | From | Ayman El-Khashab <> | Subject | Re: [PATCH v4]PPC4xx: Adding PCI(E) MSI support |
| |
On Thu, May 26, 2011 at 03:24:44PM +1000, Benjamin Herrenschmidt wrote: > > Please check the result and send any "fixup" patch that might be > necessary. > > > +static int ppc4xx_setup_pcieh_hw(struct platform_device *dev, > > + struct resource res, struct ppc4xx_msi *msi) > > +{ > > +
<snip>
> > + > > + msi->msi_dev = of_find_node_by_name(NULL, "ppc4xx-msi"); > > + if (msi->msi_dev) > > + return -ENODEV;
This does not look correct. I guess it should probably read
if (!msi->msi_dev) .....
Ayman
| |