lkml.org 
[lkml]   [2011]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/11] dynamic_debug: return int from ddebug_change
    Date
    Alter ddebug_change to return number of matches found for query/rule.
    This lets caller know whether rule applied, and potentially what
    to do next.

    Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
    ---
    lib/dynamic_debug.c | 11 ++++++-----
    1 files changed, 6 insertions(+), 5 deletions(-)

    diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
    index 97f6a9b..9b8b1e8 100644
    --- a/lib/dynamic_debug.c
    +++ b/lib/dynamic_debug.c
    @@ -102,8 +102,8 @@ static char *ddebug_describe_flags(struct _ddebug *dp, char *buf,
    * the user which ddebug's were changed, or whether none
    * were matched.
    */
    -static void ddebug_change(const struct ddebug_query *query,
    - unsigned int flags, unsigned int mask)
    +static int ddebug_change(const struct ddebug_query *query,
    + unsigned int flags, unsigned int mask)
    {
    int i;
    struct ddebug_table *dt;
    @@ -172,8 +172,7 @@ static void ddebug_change(const struct ddebug_query *query,
    }
    mutex_unlock(&ddebug_lock);

    - if (!nfound && verbose)
    - pr_info("no matches for query\n");
    + return nfound;
    }

    /*
    @@ -425,6 +424,7 @@ static int ddebug_exec_query(char *query_string)
    #define MAXWORDS 9
    int nwords;
    char *words[MAXWORDS];
    + int nfound;

    nwords = ddebug_tokenize(query_string, words, MAXWORDS);
    if (nwords <= 0)
    @@ -435,7 +435,8 @@ static int ddebug_exec_query(char *query_string)
    return -EINVAL;

    /* actually go and implement the change */
    - ddebug_change(&query, flags, mask);
    + nfound = ddebug_change(&query, flags, mask);
    +
    return 0;
    }

    --
    1.7.4.1


    \
     
     \ /
      Last update: 2011-06-28 09:45    [W:0.044 / U:7.684 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site