| From | Jim Cromie <> | Subject | [PATCH 06/11] dynamic_debug: KERN_ERR should not depend upon verbosity | Date | Tue, 28 Jun 2011 01:09:47 -0600 |
| |
issue keyword/parsing errors even w/o verbose set; uncover otherwize mysterious non-functionality. Also convert to pr_err(), which supplies __func__ via pr_fmt.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com> --- lib/dynamic_debug.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 17bace8..7cf5fa7 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -343,9 +343,7 @@ static int ddebug_parse_query(char *words[], int nwords, query->last_lineno = query->first_lineno; } } else { - if (verbose) - printk(KERN_ERR "%s: unknown keyword \"%s\"\n", - __func__, words[i]); + pr_err("unknown keyword \"%s\"\n", words[i]); return -EINVAL; } } -- 1.7.4.1
|