lkml.org 
[lkml]   [2011]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] mm: Document handle_mm_fault()
From
Date
On Tue, 2011-06-28 at 10:02 -0700, Linus Torvalds wrote:
> On Tue, Jun 28, 2011 at 9:47 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > + * Note: if @flags has FAULT_FLAG_ALLOW_RETRY set then the mmap_sem
> > + * may be released if it failed to arquire the page_lock. If the
> > + * mmap_sem is released then it will return VM_FAULT_RETRY set.
> > + * This is to keep the time mmap_sem is held when the page_lock
> > + * is taken for IO.
>
> So I know what that flag does, but I knew it without the comment.
>
> WITH the comment, I'm just confused. "This is to keep the time
> mmap_sem is held when the page_lock is taken for IO."
>
> Sounds like a google translation from swahili. "keep the time" what?

"When people ask me what language is my mother tongue, I simply reply C"

Google translate from C -> english is worse than swahily -> english :p

>
> Maybe "keep" -> "minimize"? Or just "This is to avoid holding mmap_sem
> while waiting for IO"

OK, that sounds better. Thanks.

I'll go to cut a v2, but I'll wait a day or so for others to comment.

-- Steve




\
 
 \ /
  Last update: 2011-06-28 19:53    [W:0.122 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site