lkml.org 
[lkml]   [2011]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf, x86: Add hw_watchdog_set_attr() in a sake of nmi-watchdog on P4
On Tue, Jun 28, 2011 at 08:11:10PM +0400, Cyrill Gorcunov wrote:
>
> wd_attr->sample_period = hw_nmi_get_sample_period(watchdog_thresh);
> --> hw_nmi_watchdog_set_attr(wd_attr);
>
> itself? Ie you suspect some different point where to call it?
>
> When I said not a "best place" I meant about __weak function bare implementation
> placed that near to call (which is looked somehow suspicious for me from overall
> code structure), but I didn't mean the call sequence itself ;)

Sorry I was probably vague. What I meant to say is that the call
'hw_nmi_watchdog_set_attr' is really x86 specific and thought we could
bury it down there somehow. Yeah the __weak symbol cleverly gets around
it.

I was thinking it would be nice to stick it in hw_nmi_get_sample_period as
that is arch specific. But it really wouldn't make sense there.

It's probably fine for now and maybe someday we can come up with a better
idea where to put it.

I don't want to waste to much time thinking about it as I have other
issues I am dealing with. I just wanted to get this resolved so I can
push this patch into RHEL-6.

Cheers,
Don


\
 
 \ /
  Last update: 2011-06-28 18:51    [W:0.049 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site