lkml.org 
[lkml]   [2011]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/8] blk-throttle: do not enforce first queued bio check in tg_wait_dispatch
    Date
    Soon we will be using same wait routines for checking the wait for
    task also and no bio is involved. So get rid of any bio dependencies
    and leave it to caller that if and bio or task is queued in the group
    in same direction, then don't call this routine.

    Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
    ---
    block/blk-throttle.c | 8 --------
    1 files changed, 0 insertions(+), 8 deletions(-)

    diff --git a/block/blk-throttle.c b/block/blk-throttle.c
    index d76717a..8facd17 100644
    --- a/block/blk-throttle.c
    +++ b/block/blk-throttle.c
    @@ -696,14 +696,6 @@ tg_wait_dispatch(struct throtl_data *td, struct throtl_grp *tg, struct bio *bio)
    bool rw = bio_data_dir(bio);
    unsigned long bps_wait = 0, iops_wait = 0, max_wait = 0;

    - /*
    - * Currently whole state machine of group depends on first bio
    - * queued in the group bio list. So one should not be calling
    - * this function with a different bio if there are other bios
    - * queued.
    - */
    - BUG_ON(tg->nr_queued[rw] && bio != bio_list_peek(&tg->bio_lists[rw]));
    -
    /* If tg->bps = -1, then BW is unlimited */
    if (tg->bps[rw] == -1 && tg->iops[rw] == -1)
    return 0;
    --
    1.7.4.4


    \
     
     \ /
      Last update: 2011-06-28 17:45    [W:2.232 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site