Messages in this thread | | | Date | Tue, 28 Jun 2011 08:39:28 +0200 | Subject | Re: [PATCH 3/3] char drivers: ramoops record_size module parameter | From | Marco Stornelli <> |
| |
Hi,
2011/6/28 Sergiu Iordache <sergiu@chromium.org>: > The size of the dump is currently set using the RECORD_SIZE macro which > is set to a page size. This patch makes the record size a module > parameter and allows it to be set through platform data as well to allow > larger dumps if needed. > > Change-Id: Ie6bd28a898dab476abf34decb0eecc42122f17ce > Signed-off-by: Sergiu Iordache <sergiu@chromium.org> > ---
the idea can be valid, but you have to add some check to set the record size. It'd be better to add a lower and upper bound and to check for it's power of two.
Marco
| |