[lkml]   [2011]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 2/3] ext4: Explicitly specify fsync dependency on journaling thread
    Set/reset fsync dependency of fsync on journalling thread. This allows
    CFQ to dispatch IO from journalling thread in fsync's time slice.
    Otherwise, lots of cfq queue idling takes place if fsync is running
    in a separate cgroup and journalling thread is running in root group.

    Signed-off-by: Vivek Goyal <>
    fs/ext4/fsync.c | 3 +++
    1 files changed, 3 insertions(+), 0 deletions(-)

    diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
    index ce66d2f..8b16a90 100644
    --- a/fs/ext4/fsync.c
    +++ b/fs/ext4/fsync.c
    @@ -216,7 +216,10 @@ int ext4_sync_file(struct file *file, int datasync)
    !jbd2_trans_will_send_data_barrier(journal, commit_tid))
    needs_barrier = true;
    jbd2_log_start_commit(journal, commit_tid);
    + blk_set_depends_on_task(journal->j_dev->bd_disk->queue,
    + journal->j_task);
    ret = jbd2_log_wait_commit(journal, commit_tid);
    + blk_reset_depends_on_task(journal->j_dev->bd_disk->queue);
    if (needs_barrier)
    blkdev_issue_flush(inode->i_sb->s_bdev, GFP_KERNEL, NULL);

     \ /
      Last update: 2011-06-27 22:23    [W:0.035 / U:24.180 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site