Messages in this thread | | | Subject | Re: [PATCH 2/2] mtd/ofpart: add ofoldpart alias | From | Artem Bityutskiy <> | Date | Mon, 27 Jun 2011 09:03:26 +0300 |
| |
On Mon, 2011-06-27 at 09:51 +0400, Dmitry Eremin-Solenikov wrote: > On 6/27/11, Artem Bityutskiy <dedekind1@gmail.com> wrote: > > On Mon, 2011-06-27 at 01:03 +0400, Dmitry Eremin-Solenikov wrote: > >> ofpart.ko also provides ofoldpart MTD parser. Add respective > >> MODULE_ALIAS("ofoldpart"); declaration. > >> > > > > Why we need the alias? > > Please check the parse_mtd_partitions code. If requested parser > isn't registered, it tries to load corresponding module. So, this alias > is necessary in the semi-bogus case when one will have the list > of parsers containing ofoldpart, but not ofpart partition parser.
Fair enough, but would you please prepend MODULE_ALIAS with a comment like this which explains why we need the alias?
-- Best Regards, Artem Bityutskiy
| |