lkml.org 
[lkml]   [2011]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH resend 2/6] dm: use use proper little-endian bitops
    Date
    Using __test_and_{set,clear}_bit_le() with ignoring its return value
    can be replaced with __{set,clear}_bit_le().

    This also removes unnecessary casts.

    Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
    Cc: Alasdair Kergon <agk@redhat.com>
    Cc: dm-devel@redhat.com
    ---
    drivers/md/dm-log.c | 9 ++++-----
    1 files changed, 4 insertions(+), 5 deletions(-)

    diff --git a/drivers/md/dm-log.c b/drivers/md/dm-log.c
    index 948e3f4..2ef7e6e 100644
    --- a/drivers/md/dm-log.c
    +++ b/drivers/md/dm-log.c
    @@ -251,20 +251,20 @@ struct log_c {
    */
    static inline int log_test_bit(uint32_t *bs, unsigned bit)
    {
    - return test_bit_le(bit, (unsigned long *) bs) ? 1 : 0;
    + return test_bit_le(bit, bs) ? 1 : 0;
    }

    static inline void log_set_bit(struct log_c *l,
    uint32_t *bs, unsigned bit)
    {
    - __test_and_set_bit_le(bit, (unsigned long *) bs);
    + __set_bit_le(bit, bs);
    l->touched_cleaned = 1;
    }

    static inline void log_clear_bit(struct log_c *l,
    uint32_t *bs, unsigned bit)
    {
    - __test_and_clear_bit_le(bit, (unsigned long *) bs);
    + __clear_bit_le(bit, bs);
    l->touched_dirtied = 1;
    }

    @@ -739,8 +739,7 @@ static int core_get_resync_work(struct dm_dirty_log *log, region_t *region)
    return 0;

    do {
    - *region = find_next_zero_bit_le(
    - (unsigned long *) lc->sync_bits,
    + *region = find_next_zero_bit_le(lc->sync_bits,
    lc->region_count,
    lc->sync_search);
    lc->sync_search = *region + 1;
    --
    1.7.4.4


    \
     
     \ /
      Last update: 2011-06-26 07:59    [W:0.031 / U:59.932 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site