Messages in this thread | | | Date | Sun, 26 Jun 2011 18:47:37 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH v3 2/2] fadvise: implement POSIX_FADV_NOREUSE |
| |
On 06/24/2011 09:49 AM, Andrea Righi wrote:
> @@ -114,7 +114,8 @@ SYSCALL_DEFINE(fadvise64_64)(int fd, loff_t offset, loff_t len, int advice) > ret = 0; > break; > case POSIX_FADV_NOREUSE: > - break; > + /* Reduce cache eligibility */ > + force = false; > case POSIX_FADV_DONTNEED: > if (!bdi_write_congested(mapping->backing_dev_info)) > filemap_flush(mapping);
And the same is true here. "force" is just not a very descriptive name.
> @@ -124,8 +125,8 @@ SYSCALL_DEFINE(fadvise64_64)(int fd, loff_t offset, loff_t len, int advice) > end_index = (endbyte>> PAGE_CACHE_SHIFT); > > if (end_index>= start_index) > - invalidate_mapping_pages(mapping, start_index, > - end_index); > + __invalidate_mapping_pages(mapping, start_index, > + end_index, force); > break; > default: > ret = -EINVAL;
-- All rights reversed
| |