lkml.org 
[lkml]   [2011]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [AX25] inconsistent lock state
    Hi,

    I applied the patch and since then I could not reproduce the
    inconsistent lock state.
    Thus mkiss patch fixed it.

    Thanks,

    Bernard

    Le 17/06/2011 16:11, Arnd Bergmann a écrit :
    > On Friday 17 June 2011 15:51:48 Ralf Baechle wrote:
    >> On Fri, Jun 17, 2011 at 03:36:15PM +0200, Arnd Bergmann wrote:
    >>
    >> (Removed Jarek from cc; his email bounces.)
    >>
    >>> The message hints that disc_data_lock is aquired with softirqs disabled,
    >>> but does not itself disable softirqs, which can in rare circumstances
    >>> lead to a deadlock.
    >>>
    >>> Does this fix it?
    >> If so, drivers/net/hamradio.c, function sp_get() would probably need the
    >> equivalent fix. Same for drivers/net/ppp_async.c:ap_get() and sp_get() in
    >> drivers/net/ppp_synctty.c.
    > It seems that ppp_synctty.c is ok, it uses write_lock_irq() already,
    > sixpack.c looks like it has the same bug as mkiss. I also realized
    > after sending out the patch that only the write_lock needs to be
    > changed to write_lock_bh, while read_lock can leave softirqs enabled
    > because it can be called recursively.
    >
    > Arnd

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-06-25 17:55    [W:2.217 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site