Messages in this thread | | | Date | Sat, 25 Jun 2011 22:39:24 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [PATCH] PCI / PM: Block races between runtime PM and system sleep |
| |
On Fri, 24 Jun 2011, Rafael J. Wysocki wrote:
> > > I'm still not clear on why the error handler needs to run at this time. > > > > Because SATA ports are suspended with the help of the SCSI error handling > > mechanism (which Tejun claims is the best way to do that).
> I've carried out this exercise to see how complicated it is going to be > and it doesn't really seem to be _that_ complicated. The appended patch > illustrates this, but it hasn't been tested, so caveat emptor.
The patch is straightforward enough. But will it be sufficient?
Suppose a SATA port is already in runtime suspend when the system sleep starts. Will the error handler be able to do its special job? I don't know... It may turn out to be necessary for the SATA port to be runtime resumed somewhere along the line.
Alan Stern
| |