[lkml]   [2011]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] net, llc: Avoid undefined behaviour in llc_conn_ac_inc_vr_by_1()
    On Sat, 25 Jun 2011, David Miller wrote:

    > From: Jesper Juhl <>
    > Date: Sun, 26 Jun 2011 00:11:12 +0200 (CEST)
    > > Introduce a sequence point (;) between two writes to llc_sk(sk)->vR in
    > > net/llc/llc_c_ac.c:llc_conn_ac_inc_vr_by_1() so that the order in
    > > which the writes happen become well defined.
    > >
    > > While the code may work fine now it may break at any time with a
    > > different compiler, a new version of current compiler or even just a
    > > different optimization level of the current compiler. Much better to
    > > clearly express what's intended in a way that guarantees the result.
    > >
    > > Signed-off-by: Jesper Juhl <>
    > How about fixing the macro so that it doesn't have side effects
    > like this?
    > That's much better than a 6 line (improperly formatted, BTW) comment
    > every time someone tried to use that macros with an lvalue that isn't
    > a local variable.

    Sure, that's also a way to go - better probably.
    I just thought that I would fix up the one call site I found that was
    But gimme a couple of days (I don't have much free time) and I'll cook up
    a different patch.

    Jesper Juhl <>
    Don't top-post
    Plain text mails only, please.

     \ /
      Last update: 2011-06-26 02:13    [W:0.061 / U:144.972 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site