lkml.org 
[lkml]   [2011]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] SOUND: Fix non-ISA_DMA_API build failure
On Fri, Jun 24, 2011 at 08:35:22AM -0300, Mauro Carvalho Chehab wrote:

> Em 24-06-2011 08:16, Ralf Baechle escreveu:
> > tristate "miroSOUND PCM20 radio"
> > depends on ISA && VIDEO_V4L2 && SND
> > select SND_ISA
> > select SND_MIRO
> >
> > So SND_ISA gets forced on even though the dependency on ISA_DMA_API is not
> > fulfilled. That's solved by adding the dependency on ISA_DMA_API to
> > RADIO_MIROPCM20.
>
> Another option would be to convert the two above selects into depends on.

Depends has the disadvantage that users may have to enable unobvious
options first before they are offered the one they are looking for and
that's what a "depends SND_ISA" would cause in this case.

Ralf


\
 
 \ /
  Last update: 2011-06-24 14:11    [W:0.058 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site