lkml.org 
[lkml]   [2011]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] SOUND: Fix non-ISA_DMA_API build failure
    Em 24-06-2011 08:16, Ralf Baechle escreveu:
    > On Fri, Jun 24, 2011 at 10:26:13AM +0200, Takashi Iwai wrote:
    >
    >> Hrm... I still don't understand why ES18XX or others were selected at
    >> the first place. Isn't it covered by the conditional in
    >> sound/isa/Kconfig like below?
    >>
    >> ================================================================
    >> menuconfig SND_ISA
    >> bool "ISA sound devices"
    >> depends on ISA && ISA_DMA_API
    >> ...
    >> if SND_ISA
    >> ...
    >> config SND_ES18XX
    >> tristate "Generic ESS ES18xx driver"
    >> ...
    >> endif # SND_ISA
    >> ================================================================
    >>
    >> Isn't SND_ISA=n in your case although ISA_DMA_API=n?
    >
    > The answer is hidden in this Kconfig warning:
    >
    > warning: (RADIO_MIROPCM20) selects SND_ISA which has unmet direct dependencies (SOUND && !M68K && SND && ISA && ISA_DMA_API)
    >
    > This is due to the following in drivers/media/radio/Kconfig:
    >
    > config RADIO_MIROPCM20
    > tristate "miroSOUND PCM20 radio"
    > depends on ISA && VIDEO_V4L2 && SND
    > select SND_ISA
    > select SND_MIRO
    >
    > So SND_ISA gets forced on even though the dependency on ISA_DMA_API is not
    > fulfilled. That's solved by adding the dependency on ISA_DMA_API to
    > RADIO_MIROPCM20.

    Another option would be to convert the two above selects into depends on.

    Cheers,
    Mauro


    \
     
     \ /
      Last update: 2011-06-24 13:37    [W:3.683 / U:0.168 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site