lkml.org 
[lkml]   [2011]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: {PATCH] fix __packed in exported kernel headers
    On 24.6.2011 15:51, Markus Trippelsdorf wrote:
    > checkpatch.pl warns about using __attribute__((packed)) in kernel
    > headers: "__packed is preferred over __attribute__((packed))". If one
    > follows that advice it could cause problems in the exported header
    > files, because the outside world doesn't know about this shortcut.
    >
    > For example busybox will fail to compile:
    > CC miscutils/ubi_attach_detach.o
    > In file included from miscutils/ubi_attach_detach.c:27:0:
    > /usr/include/mtd/ubi-user.h:330:3: error: conflicting types for ‘__packed’
    > /usr/include/mtd/ubi-user.h:314:3: note: previous declaration of ‘__packed’ was here
    > ...
    >
    > Fix the problem by substituting __packed with __attribute__((packed)) in
    > the header_install.pl script.
    >
    > Cc: Artem Bityutskiy<Artem.Bityutskiy@nokia.com>
    > CC: Joe Perches<joe@perches.com>
    > Signed-off-by: Markus Trippelsdorf<markus@trippelsdorf.de>
    > ---
    > scripts/headers_install.pl | 1 +
    > 1 files changed, 1 insertions(+), 0 deletions(-)

    Thanks, applied to kbuild-2.6.git#kbuild.

    Michal
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-06-24 17:19    [W:0.045 / U:14.156 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site