Messages in this thread Patch in this message | | | From | Mel Gorman <> | Subject | [PATCH 3/4] mm: vmscan: Evaluate the watermarks against the correct classzone | Date | Fri, 24 Jun 2011 15:44:56 +0100 |
| |
When deciding if kswapd is sleeping prematurely, the classzone is taken into account but this is different to what balance_pgdat() and the allocator are doing. Specifically, the DMA zone will be checked based on the classzone used when waking kswapd which could be for a GFP_KERNEL or GFP_HIGHMEM request. The lowmem reserve limit kicks in, the watermark is not met and kswapd thinks its sleeping prematurely keeping kswapd awake in error.
Reported-and-tested-by: Pádraig Brady <P@draigBrady.com> Signed-off-by: Mel Gorman <mgorman@suse.de> --- mm/vmscan.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c index 9cebed1..a76b6cc2 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2341,7 +2341,7 @@ static bool sleeping_prematurely(pg_data_t *pgdat, int order, long remaining, } if (!zone_watermark_ok_safe(zone, order, high_wmark_pages(zone), - classzone_idx, 0)) + i, 0)) all_zones_ok = false; else balanced += zone->present_pages; -- 1.7.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |