lkml.org 
[lkml]   [2011]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH 1/3] ASoC: Add ADAV80x codec driver
On 06/23/2011 02:34 PM, Liam Girdwood wrote:
> On 23/06/11 07:00, Lars-Peter Clausen wrote:
>> This patch adds support for the Analog Devices ADAV801 and ADAV803 audio codec.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>>
>> ---
>> Changes since v1:
>> * Sync register on resume
>> * Don't use arrays for the mux enums and controls
>> * Rework PLL handling. Use DAPM for powering the PLL and OSC down and use
>> set_sysclk to select the system clock instead of doing this implicitly in
>> set_pll.
>> ---
>> MAINTAINERS | 1 +
>> sound/soc/codecs/Kconfig | 4 +
>> sound/soc/codecs/Makefile | 2 +
>> sound/soc/codecs/adav80x.c | 908 ++++++++++++++++++++++++++++++++++++++++++++
>> sound/soc/codecs/adav80x.h | 31 ++
>> 5 files changed, 946 insertions(+), 0 deletions(-)
>> create mode 100644 sound/soc/codecs/adav80x.c
>> create mode 100644 sound/soc/codecs/adav80x.h
>>
>
> snip
>
>> +
>> +static int adav80x_probe(struct snd_soc_codec *codec)
>> +{
>> + int ret;
>> + struct adav80x *adav80x = snd_soc_codec_get_drvdata(codec);
>> +
>> + ret = snd_soc_codec_set_cache_io(codec, 7, 9, adav80x->control_type);
>> + if (ret) {
>> + dev_err(codec->dev, "failed to set cache I/O: %d\n", ret);
>> + return ret;
>> + }
>> +
>> + /* Power down SYSCLK output, power down S/PDIF receiver */
>> + snd_soc_write(codec, ADAV80X_PLL_OUTE, 0x27);
>> + /* Disable DAC zero flag */
>> + snd_soc_write(codec, ADAV80X_DAC_CTRL3, 0x6);
>> +
>> + return adav80x_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
>> +}
>> +
>
> It's usually better disable things like sysclk output in your machine driver as others may depend on it for probing.

What is the proper API to do this? set_sysclk with dir = SND_SOC_CLOCK_OUT and
freq = 0?


\
 
 \ /
  Last update: 2011-06-24 02:49    [W:0.055 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site