lkml.org 
[lkml]   [2011]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[34-longterm 091/247] mptfusion: mptctl_release is required in mptctl.c
    Date
    From: Kashyap, Desai <kashyap.desai@lsi.com>

    -------------------
    This is a commit scheduled for the next v2.6.34 longterm release.
    If you see a problem with using this for longterm, please comment.
    -------------------

    commit 84857c8bf83e8aa87afc57d2956ba01f11d82386 upstream.

    Added missing release callback for file_operations mptctl_fops.
    Without release callback there will be never freed. It remains on
    mptctl's eent list even after the file is closed and released.

    Relavent RHEL bugzilla is 660871

    Signed-off-by: Kashyap Desai <kashyap.desai@lsi.com>
    Signed-off-by: James Bottomley <James.Bottomley@suse.de>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    drivers/message/fusion/mptctl.c | 8 ++++++++
    1 files changed, 8 insertions(+), 0 deletions(-)

    diff --git a/drivers/message/fusion/mptctl.c b/drivers/message/fusion/mptctl.c
    index caa8f56..4e12556 100644
    --- a/drivers/message/fusion/mptctl.c
    +++ b/drivers/message/fusion/mptctl.c
    @@ -577,6 +577,13 @@ mptctl_event_process(MPT_ADAPTER *ioc, EventNotificationReply_t *pEvReply)
    }

    static int
    +mptctl_release(struct inode *inode, struct file *filep)
    +{
    + fasync_helper(-1, filep, 0, &async_queue);
    + return 0;
    +}
    +
    +static int
    mptctl_fasync(int fd, struct file *filep, int mode)
    {
    MPT_ADAPTER *ioc;
    @@ -2778,6 +2785,7 @@ static const struct file_operations mptctl_fops = {
    .llseek = no_llseek,
    .fasync = mptctl_fasync,
    .unlocked_ioctl = mptctl_ioctl,
    + .release = mptctl_release,
    #ifdef CONFIG_COMPAT
    .compat_ioctl = compat_mpctl_ioctl,
    #endif
    --
    1.7.4.4


    \
     
     \ /
      Last update: 2011-06-23 20:21    [W:0.019 / U:1.892 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site