lkml.org 
[lkml]   [2011]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[34-longterm 066/247] pata_mpc52xx: inherit from ata_bmdma_port_ops
    Date
    From: Tejun Heo <tj@kernel.org>

    -------------------
    This is a commit scheduled for the next v2.6.34 longterm release.
    If you see a problem with using this for longterm, please comment.
    -------------------

    commit 77c5fd19075d299fe820bb59bb21b0b113676e20 upstream.

    pata_mpc52xx supports BMDMA but inherits ata_sff_port_ops which
    triggers BUG_ON() when a DMA command is issued. Fix it.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Reported-by: Roman Fietze <roman.fietze@telemotive.de>
    Cc: Sergei Shtylyov <sshtylyov@mvista.com>
    Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    drivers/ata/pata_mpc52xx.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
    index 9f5b053..e80ebcb 100644
    --- a/drivers/ata/pata_mpc52xx.c
    +++ b/drivers/ata/pata_mpc52xx.c
    @@ -610,7 +610,7 @@ static struct scsi_host_template mpc52xx_ata_sht = {
    };

    static struct ata_port_operations mpc52xx_ata_port_ops = {
    - .inherits = &ata_sff_port_ops,
    + .inherits = &ata_bmdma_port_ops,
    .sff_dev_select = mpc52xx_ata_dev_select,
    .set_piomode = mpc52xx_ata_set_piomode,
    .set_dmamode = mpc52xx_ata_set_dmamode,
    --
    1.7.4.4


    \
     
     \ /
      Last update: 2011-06-23 20:05    [W:4.331 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site