Messages in this thread | | | Date | Thu, 23 Jun 2011 14:36:05 +0100 | From | Matthew Garrett <> | Subject | Re: [PATCH] kernel: escape non-ASCII and control characters in printk() |
| |
On Wed, Jun 22, 2011 at 08:37:42AM -0700, Greg KH wrote: > On Wed, Jun 22, 2011 at 01:53:41PM +0400, Vasiliy Kulikov wrote: > > This patch escapes all characters outside of allowed '\n' plus 0x20-0x7E > > charset passed to printk(). > > > > There are numerous printk() instances with user supplied input as "%s" > > data, and unprivileged user may craft log messages with substrings > > containing control characters via these printk()s. Control characters > > might fool root viewing the logs via tty. > > There are "numerous" places this could happen?
USB product identifiers?
-- Matthew Garrett | mjg59@srcf.ucam.org
| |