Messages in this thread | | | Date | Thu, 23 Jun 2011 15:27:54 +0200 | From | Tejun Heo <> | Subject | Re: [PATCH 2/8] kill tracehook_notify_death() |
| |
Hey,
On Thu, Jun 23, 2011 at 03:21:26PM +0200, Oleg Nesterov wrote: > > > This also fixes a minor bug, if the exiting task is the group_leader > > > and it is traced by its real_parent, tracehook_notify_death() returns > > > task->exit_signal or SIGCHLD depending on thread_group_empty(), this > > > looks strange. > > > > Maybe we should do the above in a separate patch? > > Do you think this makes sense? OK, I can do this...
Having subtle behavior change mixed with reorganization isn't too nice, so I think separating is better.
> > thread_group_leader() seems unnecessarily indirect. > > This is what I disagree with. Contrary, I think thread_group_leader() exactly > explains what do we want to check. (but once again, exec_id logic should be > cleanuped, not only in this function).
Hmmm... well, this was minor to begin with and thread_group_leader() matches later patches better, so using thread_group_leader() seems fine.
Thanks.
-- tejun
| |