Messages in this thread | | | Date | Thu, 23 Jun 2011 15:25:23 +0200 | From | Tejun Heo <> | Subject | Re: [PATCH 3/8] __ptrace_detach: avoid task_detached(), check do_notify_parent() |
| |
On Wed, Jun 22, 2011 at 11:08:53PM +0200, Oleg Nesterov wrote: > __ptrace_detach() relies on the current obscure behaviour of > do_notify_parent(tsk) which changes tsk->exit_signal if this child > should be silently reaped. That is why we check task_detached(), it > is true if the task is sub-thread, or it is the group_leader but > its exit_signal was changed by do_notify_parent(). > > This is confusing, change the code to rely on !thread_group_leader() > or the value returned by do_notify_parent(). > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
This looks good to me.
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
| |