lkml.org 
[lkml]   [2011]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 06/11] spi-dw: Force error on out of range chip select.
    Date
    From: Dirk Brandewie <dirk.brandewie@gmail.com>

    BUG_ON() if the selected chip select is out of range.

    Signed-off-by: Dirk Brandewie <dirk.brandewie@gmail.com>
    ---
    drivers/spi/spi-dw.h | 3 +--
    1 files changed, 1 insertions(+), 2 deletions(-)

    diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h
    index 860bc34..3fa4c13 100644
    --- a/drivers/spi/spi-dw.h
    +++ b/drivers/spi/spi-dw.h
    @@ -178,8 +178,7 @@ static inline void spi_dw_set_clk(struct spi_dw *dws, u16 div)

    static inline void spi_dw_chip_sel(struct spi_dw *dws, u16 cs)
    {
    - if (cs > dws->num_cs)
    - return;
    + BUG_ON(cs >= dws->master->num_chipselect);

    if (dws->cs_control)
    dws->cs_control(SPI_DW_ASSERT);
    --
    1.7.3.4


    \
     
     \ /
      Last update: 2011-06-23 04:05    [W:0.021 / U:117.824 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site