Messages in this thread | | | From | Roland Dreier <> | Date | Wed, 22 Jun 2011 17:34:27 -0700 | Subject | Re: [PATCH] pch_uart: Add MSI support |
| |
On Wed, Jun 22, 2011 at 2:50 AM, Alexander Stein <alexander.stein@systec-electronic.com> wrote: > + if (priv->use_msi) > + pci_disable_msi(pdev);
Trivial nit: pci_disable_msi() is safe even if you didn't enable msi. So you can drop the use_msi flag (the PCI layer has dev->msi_enabled internally to track this), and just always call pci_disable_msi().
- R. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |