lkml.org 
[lkml]   [2011]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/8] regmap: Add generic non-memory mapped register access API
On Wed, Jun 22, 2011 at 09:03:14PM +0200, Lars-Peter Clausen wrote:
> On 06/22/2011 08:45 PM, Mark Brown wrote:

> > + if (map->bus->read_flag_bit)
> > + u8[0] |= 1 << map->bus->read_flag_bit;

> Should be 1 << (map->bus->read_flag_bit - 1)

The code has the sematic I intended; you can debate if it's the best
semantic and looking at the documentation again it's not entirely clear
so at least that should be updated.


\
 
 \ /
  Last update: 2011-06-22 21:13    [W:0.075 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site