lkml.org 
[lkml]   [2011]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Fix CPU spinlock lockups on secondary CPU bringup
From
Date
Le mercredi 22 juin 2011 à 11:55 +0100, Russell King - ARM Linux a
écrit :
> From: Russell King <rmk+kernel@arm.linux.org.uk>
>
> Secondary CPU bringup typically calls calibrate_delay() during its
> initialization. However, calibrate_delay() modifies a global variable
> (loops_per_jiffy) used for udelay() and __delay().
>
> A side effect of 71c696b1 (calibrate: extract fall-back calculation
> into own helper) introduced in the 2.6.39 merge window means that we
> end up with a substantial period where loops_per_jiffy is zero. This
> causes the spinlock debugging code to malfunction:
...

>
> + loops_per_jiffy = lpj;
> printed = true;
> }

To be 100% safe, I would use

ACCESS_ONCE(loops_per_jiffy) = lpj;

But I assume no current gcc would be that stupid ;)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-06-22 18:49    [W:0.330 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site