lkml.org 
[lkml]   [2011]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/4] mm: make the threshold of enabling THP configurable
On Wed, 22 Jun 2011, Cong Wang wrote:

> > I like the printk that notifies users why THP was disabled because it
> > could potentially be a source of confusion (and fixing the existing typos
> > in hugepage_init() would also be good). However, I disagree that we need
> > to have this as a config option: you either want the feature for your
> > systems or you don't. Perhaps add a "transparent_hugepage=force" option
> > that will act as "always" but also force it to be enabled in all
> > scenarios, even without X86_FEATURE_PSE, that will override all the logic
> > that thinks it knows better?
>
> I think that is overkill, because we can still enable THP via /sys
> for small systems.
>

That was already possible before your patch, your patch is only
introducing a configuration value that determines whether it is enabled by
default or not. I was proposing a very simple interface that would
override all logic that could be used instead when you know for certain
that you want THP enabled by default regardless of its logic. That's
extendable because it can bypass any additional code added later to
determine when it should default on or off without adding additional
config options. I wouldn't support an additional command line option, but
rather only an additional option for transparent_hugepage=.

Either way, this patch isn't needed since it has no benefit over doing it
through an init script.


\
 
 \ /
  Last update: 2011-06-22 05:31    [W:0.051 / U:1.340 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site