Messages in this thread | | | Date | Tue, 21 Jun 2011 20:24:14 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH v2 1/4] mm: completely disable THP by transparent_hugepage=0 |
| |
On Wed, 22 Jun 2011, Cong Wang wrote:
> > > Introduce "transparent_hugepage=0" to totally disable THP. > > > "transparent_hugepage=never" means setting THP to be partially > > > disabled, we need a new way to totally disable it. > > > > > > > Why can't you just compile it off so you never even compile > > mm/huge_memory.c in the first place and save the space in the kernel image > > as well? Having the interface available to enable the feature at runtime > > is worth the savings this patch provides, in my opinion. > > https://lkml.org/lkml/2011/6/20/506 >
If you're proposing a patch for a specific purpose, it's appropriate to include that in the changelog.
But now that I know what you're proposing this for, it's an easy NACK: transparent_hugepage=0 has no significant benefit over transparent_hugepage=never for kdump because the memory savings is negligible.
| |