lkml.org 
[lkml]   [2011]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/4] mm: completely disable THP by transparent_hugepage=0
On Wed, 22 Jun 2011, Cong Wang wrote:

> > > Introduce "transparent_hugepage=0" to totally disable THP.
> > > "transparent_hugepage=never" means setting THP to be partially
> > > disabled, we need a new way to totally disable it.
> > >
> >
> > Why can't you just compile it off so you never even compile
> > mm/huge_memory.c in the first place and save the space in the kernel image
> > as well? Having the interface available to enable the feature at runtime
> > is worth the savings this patch provides, in my opinion.
>
> https://lkml.org/lkml/2011/6/20/506
>

If you're proposing a patch for a specific purpose, it's appropriate to
include that in the changelog.

But now that I know what you're proposing this for, it's an easy NACK:
transparent_hugepage=0 has no significant benefit over
transparent_hugepage=never for kdump because the memory savings is
negligible.


\
 
 \ /
  Last update: 2011-06-22 05:27    [W:0.123 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site