lkml.org 
[lkml]   [2011]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v4] ahci: move ahci_sb600_softreset to libahci.c and rename it
    From
    Hello,

    On Tue, Jun 21, 2011 at 5:24 AM, Yuan-Hsin Chen <yuanlmm@gmail.com> wrote:
    >> It would be better if the name reflects that it's not for specific
    >> workaround.
    >
    > Do you mean it would be better to name it for specific workaround?

    Yes, I meant that. An extra 'not' there.

    > How about ahci_bad_pmp_check_ready? Because this function is
    > to avoid checking TFDATA if BAD PMP is found.

    It's minor anyway and I don't think it matters all that much as long
    as we make the actual reset and ops names not too confusing.

    Thank you.

    --
    tejun


    \
     
     \ /
      Last update: 2011-06-21 09:19    [W:0.023 / U:30.412 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site