Messages in this thread | | | From | Paul Menage <> | Date | Tue, 21 Jun 2011 10:39:04 -0700 | Subject | Re: [RFC PATCH 1/4] cgroups: Allow a cgroup subsys to reject a fork |
| |
On Sun, Jun 19, 2011 at 4:51 PM, Frederic Weisbecker <fweisbec@gmail.com> wrote: > Make the cgroup subsystem fork callback return a value > so that subsystems are able to accept or reject a fork > completion with a custom error value.
This is unnecessary complexity in the cgroup subsystem (and seems to miss cleanup for subsystems that have previously had their fork() method return success).
If you want a subsystem to be able to reject a fork, I think it's better to have that subsystem be called explicitly from do_fork(), and keep that logic out of cgroups.
Paul
| |