lkml.org 
[lkml]   [2011]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/15] xen/trace: add multicall tracing
On Tue, Jun 21, 2011 at 10:11:25AM -0700, Jeremy Fitzhardinge wrote:
> On 06/21/2011 06:52 AM, Konrad Rzeszutek Wilk wrote:
> >> +TRACE_EVENT(xen_mc_entry,
> >> + TP_PROTO(struct multicall_entry *mc, unsigned nargs),
> >> + TP_ARGS(mc, nargs),
> >> + TP_STRUCT__entry(
> >> + __field(unsigned short, op)
> >> + __field(unsigned short, nargs)
> >> + __array(unsigned long, args, 6)
> > Not 'unsigned long' for op?
>
> I wanted to save space in the trace buffer. I think hypercall numbers
> are all small?

OK, but then the next entry (not shown here) used 'unsigned long' for the 'op' as well.


\
 
 \ /
  Last update: 2011-06-21 19:25    [W:4.564 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site