lkml.org 
[lkml]   [2011]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v4 3.0-rc2-tip 14/22] 14: x86: uprobes exception notifier for x86.
    From
    Date
    On Tue, 2011-06-07 at 18:31 +0530, Srikar Dronamraju wrote:
    > @@ -844,6 +845,19 @@ do_notify_resume(struct pt_regs *regs, void *unused, __u32 thread_info_flags)
    > if (thread_info_flags & _TIF_SIGPENDING)
    > do_signal(regs);
    >
    > + if (thread_info_flags & _TIF_UPROBE) {
    > + clear_thread_flag(TIF_UPROBE);
    > +#ifdef CONFIG_X86_32
    > + /*
    > + * On x86_32, do_notify_resume() gets called with
    > + * interrupts disabled. Hence enable interrupts if they
    > + * are still disabled.
    > + */
    > + local_irq_enable();
    > +#endif
    > + uprobe_notify_resume(regs);
    > + }

    Would it make sense to do TIF_UPROBE before TIF_SIGPENDING? That way
    when uprobe decides it ought to have send a signal we don't have to do
    another loop through all this.


    \
     
     \ /
      Last update: 2011-06-21 15:35    [W:5.075 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site