[lkml]   [2011]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/2] Exynos4 NURI: configure regulators and PMIC
    On Mon, Jun 20, 2011 at 04:58:09PM +0900, MyungJoo Ham wrote:

    > However, the MAX8997 driver uses platform_data's entry (variables
    > defined in "static struct max8997_platform_data __initdata
    > nuri_max8997_pdata)
    > in its normal functions other than its probe function, which are often
    > called after boot.

    That's bad practice on its part.

    > I just can't sure whether I should let probe function copy
    > platform-data used by non-probe functions to its own local data

    This is the best fix.

     \ /
      Last update: 2011-06-20 12:33    [W:0.018 / U:9.744 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site