Messages in this thread | | | Date | Mon, 20 Jun 2011 09:36:56 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/8] x86, mce: stop calling del_timer_sync() from interrupt |
| |
On Mon, Jun 20, 2011 at 12:46:28AM -0400, Hidetoshi Seto wrote: > > You're adding the mce_available(..) check just to remove it in the next > > patch. Since all those sysfs nodes are behind such a check, there's no > > need for it here too. > > Maybe it would be better to change the order of patches to make > this fix after the removal of unnecessary mce_available().
Yes, and then don't add it to mce_timer_delete_all because this functionality is guarded my mce_available() checks in the sysfs nodes init path.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |