lkml.org 
[lkml]   [2011]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/8] regmap: Add generic non-memory mapped register access API
On Tue, Jun 21, 2011 at 02:45:53AM +0200, Lars-Peter Clausen wrote:
> On 06/21/2011 02:14 AM, Mark Brown wrote:

> > I like init, especially considering the plan to add cache support as
> > there's more work in setting that up once you start doing the advanced
> > caches.

> If you take a look at other kernel apis _alloc is usually used if the structure
> is allocated (and initialized) inside the function and _init is used when the
> function initializes an already existing structure. And it also matches better

That more applies to split alloc/init models - here there's a single
operation that does both. To me alloc() generally means that it just
allocates a structure and leaves initialization still to be done while.

> with regmap_free.

That's true.


\
 
 \ /
  Last update: 2011-06-21 03:27    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog