Messages in this thread | | | From | (Eric W. Biederman) | Date | Mon, 20 Jun 2011 12:50:57 -0700 | Subject | Re: [PATCH 2/2] proc: Usable inode numbers for the namespace file descriptors. |
| |
"Serge E. Hallyn" <serge@hallyn.com> writes:
> Quoting Eric W. Biederman (ebiederm@xmission.com): >> >> Assign a unique proc inode to each namespace, yielding an >> identifier that userspace can use for identifying a namespace. >> >> This has been a long requested feature and only blocked because >> a naive implementation would put the id in a global space and >> would ultimately require having a namespace for the names of >> namespaces, making migration and certain virtualization tricks >> impossible. >> >> We still don't have per superblock inode numbers for proc, which >> appears necessary for application unaware checkpoint/restart and >> migrations (if the application is using namespace filedescriptors) >> but that is now allowd by the design if it becomes important. >> >> I have preallocated the ipc and uts initial proc inode numbers so >> their structures can be statically initialized. >> >> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> > > I've not looked at the setns patches enough, but from what I can see > here it looks good. > > Acked-by: Serge Hallyn <serge@hallyn.com>
Thanks.
There are bugs in my existing proc bits that I am working on fixing so this second patch will have a small update, before it gets merged.
But posting the patches I was looking for a little review and I was announcing I had solved the technical problem of how we talk about namespaces, without needing to introduce another namespace for namespaces.
Eric
| |