lkml.org 
[lkml]   [2011]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mfd: Implement tps65910 IRQ cleanup
    On 06/20/2011 12:47 PM, Mark Brown wrote:
    > The tps65910_irq_exit() cleanup function was generating a warning from
    > sparse due to the lack of a prototype. This wasn't causing GCC warnings
    > as the driver wasn't cleaning up its IRQs on exit at all so there was no
    > use of an unprototyped function.
    >
    > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
    > ---
    > drivers/mfd/tps65910.c | 1 +
    > include/linux/mfd/tps65910.h | 1 +
    > 2 files changed, 2 insertions(+), 0 deletions(-)
    >
    > diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
    > index 2229e66..837f0e6 100644
    > --- a/drivers/mfd/tps65910.c
    > +++ b/drivers/mfd/tps65910.c
    > @@ -187,6 +187,7 @@ static int tps65910_i2c_remove(struct i2c_client *i2c)
    > struct tps65910 *tps65910 = i2c_get_clientdata(i2c);
    >
    > mfd_remove_devices(tps65910->dev);
    > + tps65910_irq_exit(tps65910);
    > kfree(tps65910);
    >
    > return 0;
    > diff --git a/include/linux/mfd/tps65910.h b/include/linux/mfd/tps65910.h
    > index 8bb85b9..efcdb29 100644
    > --- a/include/linux/mfd/tps65910.h
    > +++ b/include/linux/mfd/tps65910.h
    > @@ -791,6 +791,7 @@ int tps65910_clear_bits(struct tps65910 *tps65910, u8 reg, u8 mask);
    > void tps65910_gpio_init(struct tps65910 *tps65910, int gpio_base);
    > int tps65910_irq_init(struct tps65910 *tps65910, int irq,
    > struct tps65910_platform_data *pdata);
    > +int tps65910_irq_exit(struct tps65910 *tps65910);
    >
    > static inline int tps65910_chip_id(struct tps65910 *tps65910)
    > {
    Acked-by: Graeme Gregory <gg@slimlogic.co.uk>

    Thanks for that cleanup.

    Graeme


    \
     
     \ /
      Last update: 2011-06-20 20:57    [W:0.022 / U:98.464 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site