[lkml]   [2011]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/3] mm: make the threshold of enabling THP configurable
    于 2011年06月21日 00:59, Mel Gorman 写道:
    > On Tue, Jun 21, 2011 at 12:34:29AM +0800, Amerigo Wang wrote:
    >> Don't hard-code 512M as the threshold in kernel, make it configruable,
    >> and set 512M by default.
    > I'm not seeing the gain here either. This is something that is going to
    > be set by distributions and probably never by users. If the default of
    > 512 is incorrect, what should it be? Also, the Kconfig help message has
    > spelling errors.

    Sorry for spelling errors, I am not an English speaker.

    Hard-coding is almost never a good thing in kernel, enforcing 512
    is not good either. Since the default is still 512, I don't think this
    will affect much users.

    I do agree to improve the help message, like Dave mentioned in his reply,
    but I don't like enforcing a hard-coded number in kernel.

    BTW, why do you think 512 is suitable for *all* users?

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2011-06-20 19:19    [W:0.021 / U:17.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site