lkml.org 
[lkml]   [2011]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] PCI / PM: Block races between runtime PM and system sleep
    On Sun, 19 Jun 2011, Rafael J. Wysocki wrote:

    > From: Rafael J. Wysocki <rjw@sisk.pl>
    >
    > After commit e8665002477f0278f84f898145b1f141ba26ee26
    > (PM: Allow pm_runtime_suspend() to succeed during system suspend) it
    > is possible that a device resumed by the pm_runtime_resume(dev) in
    > pci_pm_prepare() will be suspended immediately from a work item,
    > timer function or otherwise, defeating the very purpose of calling
    > pm_runtime_resume(dev) from there. To prevent that from happening
    > it is necessary to increment the runtime PM usage counter of the
    > device by replacing pm_runtime_resume() with pm_runtime_get_sync().
    > Moreover, the incremented runtime PM usage counter has to be
    > decremented by the corresponding pci_pm_complete(), via
    > pm_runtime_put_noidle().

    In both this and the previous patch, the final decrement should be done
    by pm_runtime_put_sync() instead of pm_runtime_put_idle(). Otherwise
    you face the possibility that the usage_count may go to 0 but the
    device will be left active.

    Furthermore, since we're going to disable runtime PM as soon as the
    suspend callback returns anyway, why not increment usage_count before
    invoking the callback? This will prevent runtime suspends from
    occurring while the callback runs, so no changes will be needed in the
    PCI or USB subsystems.

    It also will prevent Kevin from calling pm_runtime_suspend from within
    his suspend callbacks, but you have already determined that subsystems
    and drivers should never do that in any case.

    Alan Stern



    \
     
     \ /
      Last update: 2011-06-20 16:49    [W:0.020 / U:31.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site