Messages in this thread | | | Date | Mon, 20 Jun 2011 16:45:46 +0300 | Subject | Re: [PATCH 2/2] mfd/ab8500: Use kstrtoul_from_user | From | Alexey Dobriyan <> |
| |
NAK You should use kstrtou8_from_user() and drop 0xff check as well.
Do NOT blindly replace strict_strtoul with kstrtoul.
On Mon, Jun 6, 2011 at 11:43 PM, Peter Huewe <peterhuewe@gmx.de> wrote: > - err = strict_strtoul(buf, 0, &user_val); > + err = kstrtoul_from_user(user_buf, count, 0, &user_val); > if (err) > - return -EINVAL; > + return err; > + > if (user_val > 0xff) { > dev_err(dev, "debugfs error input > 0xff\n"); > return -EINVAL; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |