lkml.org 
[lkml]   [2011]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/9] perf python: Fix argument name list of read_on_cpu()
    Date
    From: Frederic Weisbecker <fweisbec@gmail.com>

    Mandatory arguments need to be present in the argument name list, as
    well as optional arguments, otherwise python barfs:

    # ./python/twatch.py
    Traceback (most recent call last):
    File "./python/twatch.py", line 41, in <module>
    main()
    File "./python/twatch.py", line 32, in main
    event = evlist.read_on_cpu(cpu)
    RuntimeError: more argument specifiers than keyword list entries

    Hence, add cpu to the name list.

    Cc: David Ahern <daahern@cisco.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: Tom Zanussi <tzanussi@gmail.com>
    Link: http://lkml.kernel.org/r/1301588863-20210-1-git-send-email-fweisbec@gmail.com
    Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/python.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c
    index 24063b4..a9ac050 100644
    --- a/tools/perf/util/python.c
    +++ b/tools/perf/util/python.c
    @@ -674,7 +674,7 @@ static PyObject *pyrf_evlist__read_on_cpu(struct pyrf_evlist *pevlist,
    struct perf_evlist *evlist = &pevlist->evlist;
    union perf_event *event;
    int sample_id_all = 1, cpu;
    - static char *kwlist[] = {"sample_id_all", NULL, NULL};
    + static char *kwlist[] = {"cpu", "sample_id_all", NULL, NULL};
    int err;

    if (!PyArg_ParseTupleAndKeywords(args, kwargs, "i|i", kwlist,
    --
    1.6.2.5


    \
     
     \ /
      Last update: 2011-06-02 22:59    [W:0.036 / U:29.848 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site