Messages in this thread | | | From | Mike Frysinger <> | Date | Thu, 2 Jun 2011 10:53:18 -0400 | Subject | Re: [PATCH 2/2] atomic: move atomic_add_unless to generic code |
| |
On Tue, May 31, 2011 at 17:17, Arun Sharma wrote: > On 5/31/11 1:21 PM, Mike Frysinger wrote: >> On Tue, May 31, 2011 at 15:10, Arun Sharma wrote: >>> >>> This is in preparation for more generic atomic >>> primitives based on __atomic_add_unless. >> >> i think you might have to have those primitives in place before this >> patch makes sense. the only thing this does is hoist a single >> comparison out of arch atomic.h's and into linux/atomic.h. this >> savings alone looks simply like over engineering to me. > > Some of the context is buried in the lkml-reference. The main motivation for > the patch is commit 686a7e3. > > The idea is to move atomic_add_unless_return() into linux/atomic.h
my point is that that patchset doesnt seem to exist yet, and it'd probably make sense to have it ready and part of this series before attempting to push this. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |