lkml.org 
[lkml]   [2011]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 9/10 v2] Generic Watchdog Timer Driver
Date
On Sunday 19 June 2011 12:01:41 Alan Cox wrote:
> > Hmm, I'm not sure about this one. It does make the conversion
> > of existing drivers easier but doesn't encourage doing a good
> > job there.
>
> It's not ultimately about conversion. A lot of watchdogs have interfaces
> that are not quite generic, extra requirements and custom interfaces. The
> ioctl interface is needed for that, not for conversions.

It's probably fine to have additional custom interfaces in some watchdogs
where needed, but do you think we also need to give drivers a way to
override the common ones?

If a driver has a different interpretation of a common command, I would
consider that a bug, not a driver specific extension. I would also
like to see the proper extensions easily visible, so we can create
new common interfaces in cases where multiple drivers have the same
requirement.

Arnd


\
 
 \ /
  Last update: 2011-06-19 13:31    [from the cache]
©2003-2011 Jasper Spaans