lkml.org 
[lkml]   [2011]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/12] vmscan: add shrink_slab tracepoints
    (2011/06/02 16:00), Dave Chinner wrote:
    > From: Dave Chinner <dchinner@redhat.com>
    >
    > Іt is impossible to understand what the shrinkers are actually doing
    > without instrumenting the code, so add a some tracepoints to allow
    > insight to be gained.
    >
    > Signed-off-by: Dave Chinner <dchinner@redhat.com>
    > ---
    > include/trace/events/vmscan.h | 67 +++++++++++++++++++++++++++++++++++++++++
    > mm/vmscan.c | 6 +++-
    > 2 files changed, 72 insertions(+), 1 deletions(-)

    This look good to me. I have two minor request. 1) please change patch order,
    move this patch after shrinker changes. iow, now both this and [2/12] have
    tracepoint change. I don't like it. 2) please avoid cryptic abbreviated variable
    names. Instead, please just use the same variable name with vmscan.c source code.


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-06-20 02:47    [W:0.042 / U:63.484 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site