lkml.org 
[lkml]   [2011]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: reorganized struct inode results in unaligned accesses
    Date
    Linus Torvalds <torvalds@linux-foundation.org> writes:
    >
    > Dang. I guess it needs to be made "unsigned long" again. Which is a
    > shame, because we only use a couple of bits from there, and "struct
    > inode" really is much too big already.

    In the past it was usually enough to just align it to alignof(unsigned
    long), not actually make it long. struct page went through this
    a long time ago.

    This could cause r-m-w races with the next field in theory, but assuming
    it's reasonably read-only (ie only set up at inode creation time)
    that should be fine.

    -Andi

    --
    ak@linux.intel.com -- Speaking for myself only


    \
     
     \ /
      Last update: 2011-06-20 00:39    [W:0.019 / U:122.120 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site