lkml.org 
[lkml]   [2011]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] USB: ehci: use packed,aligned(4) instead of removing the packed attribute
Date
On Sunday 19 June 2011 22:02:23 Arnd Bergmann wrote:
> In this case, we would have to do
>
> struct s {
> char c[2];
> } __packed;
>
> struct t {
> struct s t1;
> unsigned short t2[3] __aligned(2);
> } __packed;
>
> To tell the compiler that t2 is indeed aligned, while struct t
> is packed to include no padding around t.
>
> I actually recently stumbled over code that gets this wrong,
> see
>
> http://git.kernel.org/?p=linux/kernel/git/arnd/playground.git;a=commit;h=284cef173aafd531a708f48e71a9cc7249fc8a98
>

Just to be clear: none of the ehci structures fall into this category.
I would assume that we actually have a few more drivers with this
bug in the kernel, but the patch proposed by Alexander would not
help with this problem, and the EHCI driver is still correct without
__packed.

Arnd


\
 
 \ /
  Last update: 2011-06-19 22:15    [W:0.100 / U:1.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site